CHANGE to use changelog uri from rubygems metadata#171
Merged
Conversation
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gem_updaterworks.We used to try to guess where the changelog was located by opening the repository’s page, and scrap it to find where the changelog is located. This had its downsides, mainly we were quite dependant of the markup of the page, which could change if github decided to, also this was just a guess as the changelog could have been named
CHANGELOG.md,NEWS.txt,changes, or whatever else.Instead we will now rely on the gem’s metadata, which MAY include a property
changelog_uri. If this property is there, then this is where our changelog is, and the only ice on the cake is that we look for an anchor that matches the version we updated to. If the property is not there, this is a good opportunity for an easy contribution on the gem’s repository to add where its changelog is located, but that won’t be the responsibility ofgem_updaterto try to find it.