Patch time ago #256
Closed
Patch time ago #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, avoiding constantly reinstantiating it (which is a performance hit when performing multiple consecutive Date manipulations)
…d reading an incorrect number of hours apart.
|
My apologies - this PR accidentally includes some other tweaks. Let me close and try again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix for #243 where the
timeAgofunction would fail to return an adequate result ofyesterday. Looking at the code, it definesyesterdayasdate.subtract(1.day):But
dateisn't always the later of the two dates, and the code actually computes which of the two dates should be thelatestand which should be theearliest. They're just not being used here. The patch fixes this by ensuring that "yesterday" is the latest date minus 1 day.