Implement workaround for print iframe removal on focus event #764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @sensasi-delight, thanks so much for this! I've been trying to think of situations where this might not work, or if it might cause problems for anything. Going to think about it for a few more days and then will merge if nothing comes up. Really appreciate you looking into this! |
|
Thank you for the response! Please let me know if there's anything I can clarify or improve further. I'm happy to help. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces an important update to the
startPrintfunction in thesrc/utils/startPrint.tsfile. The update implements a workaround to address the issue where the print iframe is removed immediately after the print dialog closes. This fixes the problem described in issue #187, where the iframe was being removed too early—before the print dialog appeared—causing the print preview to display the entire UI instead of the intended content.src/utils/startPrint.ts: Added afocusevent listener to remove the print iframe after the print dialog closes, addressing the lack of a reliableafterprintevent in most browsers.