-
-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing style and weight definition when using custom fonts #565
Conversation
Hi, thanks for the PR! Would you mind also updating the examples to show using this? I use the examples as both a way to show people how to use things, and also as tests to ensure everything is working properly. Otherwise everything looks good! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, happy new year! Apologies for not getting this merged sooner, I had to do some other things in the final weeks of last year. I looked at this locally, and it exposed a bug in the underlying code, which I have fixed and is now available as v2.14.11
. If you rebase on that it should work.
I have a few improvements I'd like to see to the Webpack stuff here. I'll make a PR into your fork tomorrow hopefully to show what I'm getting at. I do want to get this merged. Thanks!
Sorry, I missed review the notification. I have rebase and adapted the code based on your comments. I tested locally and it works great now! |
Hi, any progress of merging this into master? We could really use the functionality of this PR :). |
Ah, my bad guys, I had the tab open here but it got buried. Thanks for the reminder, and for fixing this up! |
Published in |
Goal
Allow to define custom font
style
andweight
.Example
Documentation: https://developer.mozilla.org/en-US/docs/Web/API/FontFace