Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use append child #344

Merged
merged 3 commits into from
Feb 6, 2021
Merged

Use append child #344

merged 3 commits into from
Feb 6, 2021

Conversation

MatthewHerbst
Copy link
Owner

Closes #341

Two bug fixes:

  1. use appendChild instead of append since append isn't supported by IE11
  2. ensure we allow printing of bare string components

Bonus: devDependency upgrades

@MatthewHerbst
Use appendChild instead of append when append is not available
510c78d 
This provides better workings with IE, especially since it is
somewhat difficult to always ensure polyfills work within iframes.

The core difference from our perspective is that `append` allows
Node or DOMString obejcts while `appendChild` only allows Node
objects.

https://developer.mozilla.org/en-US/docs/Web/API/ParentNode/append
https://developer.mozilla.org/en-US/docs/Web/API/Node/appendChild
@MatthewHerbst
Ensure bare strings work
3aadd41
@MatthewHerbst
Upgrade devDependencies
7f1772f
@MatthewHerbst MatthewHerbst added bug IE dependencies Pull requests that update a dependency file labels Feb 6, 2021
@MatthewHerbst MatthewHerbst merged commit 9f25286 into master Feb 6, 2021
@MatthewHerbst MatthewHerbst deleted the use-appendChild branch February 6, 2021 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug dependencies Pull requests that update a dependency file IE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Print not working in IE11 (
1 participant
@MatthewHerbst