Edge is duplicating images

[dioscarey]

Let's' have as an option to remove the images in the header since Edge browser is duplicating the images when it attempts to print. I'm not sure if in other browsers images are required in the header but this works pretty well so far in Firefox, Chrome, and Edge on desktop.

Fixes 218

[MatthewHerbst]

Hello. I mentioned in #218 that I haven't been able to reproduce the error in Edge, and IE doesn't support codesandbox unfortunately. Do you know of a way I can test this in IE (I'm on a Mac)?

[dioscarey]

Did it in Edge 44, on a Windows 10 PC and also installed in VirtualBox cause I also use Mac, So I guess is a common issue for Edge people.

[stranzhay]

@dioscarey is it possible to release a package of your branch ?

[dioscarey]

@dioscarey is it possible to release a package of your branch ?

I made those changes in the project that Im working on and now they re in production I have no problems at the moment.

[lantanios]

In 2.6.3 all image tags are still pulled from outside of referenced div and are displayed on top of print screen. Browsers: IE 11 and Edge 42.

[MatthewHerbst]

@dioscarey does passing this prop break the printing when on Chrome or other browsers? How will a user of react-to-print know when to pass it and when not to? Will they have to do browser detection?

I want to get this fix in, but I want to make sure it's foolproof too: that it won't cause other problems for non-IE and non-Edge users

[dioscarey]

@dioscarey does passing this prop break the printing when on Chrome or other browsers? How will a user of react-to-print know when to pass it and when not to? Will they have to do browser detection?

I want to get this fix in, but I want to make sure it's foolproof too: that it won't cause other problems for non-IE and non-Edge users

That's a really good point, cause Im not quite sure why the images are passed in the header, so I thought it would be a good idea to have those images not passed to the header as optional.

In my case, I did tests on iphone, ipad, chrome, safarai and EDGE. and I had not problem not passing images to the header, but maybe in some browsers are necessary, just wanted to have that param as optional.

[MatthewHerbst]

Ok @dioscarey, thanks for checking. Could you do one more test for me please? Try passing this param and loading a really, really big image. The change that is causing all these problems (#204) was meant to solve react-to-print not waiting for large images to load.

[MatthewHerbst]

I think I have a better solution for #204 that solves this problem: https://stackoverflow.com/questions/10240110/how-do-you-cache-an-image-in-javascript testing it now

[MatthewHerbst]

I've published a new release, 2.7.0-beta.1 Could you please try it out and see if it fixes the problems?

[MatthewHerbst]

@dioscarey you can please let me know if the new 2.7.0-beta.2 solves the problem for you?

[MatthewHerbst]

Code to fix this issue was shipped in 2.7.0.