Make "pageStyle" prop may also be a function #198
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some cases we need to calculate pageStyle "just before" the print. Because of this we need to pass this prop like a function.
| @@ -144,7 +144,7 @@ The component accepts the following props (note: `?` denotes an optional prop): | |||
| | **`onAfterPrint`** | `function?` | Callback function that triggers after print | | |||
| | **`onPrintError`** | `function(errorLocation: string, error: Error)?` | Callback function that will be called if there is a printing error serious enough that printing cannot continue. Currently limited to Promise rejections in `onBeforeGetContent` or `onBeforePrint`. Use this to attempt to print again. `errorLocation` will tell you in which callback the Promise was rejected. | | |||
| | **`removeAfterPrint`** | `boolean?` | Remove the print iframe after action. Defaults to `false`. | | |||
| | **`pageStyle`** | `string?` | Override default print window styling | | |||
| | **`pageStyle`** | `string?`, `function?` | Override default print window styling. If `function` then calling in runtime just before the print. | | |||
There was a problem hiding this comment.
Should be string?|function?
|
@MatthewHerbst Thanks for review. I will provide all changes in few days. |
|
@sergeyshmakov I realize we never got this in. Did you want to add an example and then we can merge it? |
|
Going to include this in #239 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases we need to calculate pageStyle "just before" the print.
Because of this we need to pass this prop like a function.