Add new method onBeforeGetContent
#160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This method allows the user to change the contents of the page before it is retrieved for printing. This occurs before the existing `onBeforePrint` which is called after the page content has been retrieved and right before the print window is opened. Long term, it likely makes sense to change `onBeforePrint` to have this functionality, and then remove this function, since there is little use for it with this function existing.
MatthewHerbst
commented
Aug 20, 2019
Thanks, man \o/ |
|
Thank you all for you work :) I've bee watching this for the last week 🚀 |
|
Will get this released once I get #161 merged since right now a Promise rejection could result in the library still printing depending on if the user handled the error or not. |
|
Published as v2.4.0! |
Great news \o/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method allows the user to change the contents of the page before it is retrieved for printing. This occurs before the existing
onBeforePrintwhich is called after the page content has been retrieved and right before the print window is opened.Long term, it likely makes sense to change
onBeforePrintto have this functionality, and then remove this function, since there is little use for it with this function existing.