Revamp linting, fix bug found from linting #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we encountered a link that was not a STYLE tag and that had an `href` value, we would override the loop going through all the stylesheets with an inner loop, possibly causing us to miss some style sheets or to attempt to access stylesheets that did did not exist on the page.
This allows for not needing to compare against `length - 1`
|
I accidentally include another bug fix in this PR. We were seeing this error: The fix is to remove from the parent node, rather than trying to remove the node directly. We already use this method for removing the iframe if it already exists when trying to print a second time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes our linting such that
npm run lintnow works, and from that it fixes a bug that was found with linting working:When we encountered a link that was not a STYLE tag and that had an
hrefvalue, we would override the loop going through all the stylesheets with an inner loop, possibly causing us to miss some style sheets or to attempt to access stylesheets that did did not exist on the page.