Added removeAfterPrint #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatthewHerbst
requested changes
Jul 30, 2019
|
@MatthewHerbst And enjoy your vacation :) |
MatthewHerbst
approved these changes
Jul 30, 2019
|
Published as 2.3.0, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#151
I looked at the commits of the past year and I saw that the closeAfterPrint property was used when the printing was done using a window and not an iframe.
Since currently the library uses iframe for printing, I added a removeAfterPrint property which removes the iframe after printing.
For now, it defaults to false since by default the iframe was not removed and I don't want it to add a breaking change (maybe someone used the iframe after the print)