Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix static tests (scheduled) #123

Merged
merged 1 commit into from
May 11, 2023
Merged

Conversation

maxfischer2781
Copy link
Member

This PR fixes the current static tests as per failed scheduled tests.

  • Fix for flake8-bugbear check B908. Test assertions for raised exception now scope only the statement under tests.

@codecov
Copy link

codecov bot commented May 10, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (9fe2e33) 92.73% compared to head (80c4628) 92.73%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #123   +/-   ##
=======================================
  Coverage   92.73%   92.73%           
=======================================
  Files          34       34           
  Lines        1143     1143           
  Branches      166      166           
=======================================
  Hits         1060     1060           
  Misses         60       60           
  Partials       23       23           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@maxfischer2781 maxfischer2781 requested review from a team, eileen-kuehn and mschnepf and removed request for a team May 10, 2023 10:56
Copy link
Member

@mschnepf mschnepf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me 👍

Copy link
Member

@giffels giffels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@maxfischer2781 maxfischer2781 merged commit e2a11df into master May 11, 2023
@maxfischer2781 maxfischer2781 deleted the maintenance/checks_20230510 branch January 17, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants