Skip to content

Conversation

mmatera
Copy link
Contributor

@mmatera mmatera commented Nov 15, 2022

This PR is one possible implementation for the @rocky 's idea that builtins (and autoload modules) should be loaded just once.

mmatera and others added 24 commits November 6, 2022 16:51
improving clarity in Builtin.contribute
Adding comments and tests for Assignment
symbols.py:
   system_symbols() -> symbol_set(); "systems_symbols" name is too close
Symbol( System`  to module systemsymbols. Also, we now require symbols as parameters),
   not strings.

systemsymbols.py: more system symbols
It appears this was originally Pattern.create. I suspect due to bad
modularity and a lack of understandig Python that an import could be added inside the
routine, this static method got moved outside of the class.

Later on, the modularity was fixed, but the hack persisted. These kinds
of code smells side effects of poor communication.
* More apply() -> eval() cutovers in the changed files
* Some <dt> indentation regularization.
* DRY redundant "argr" message definitions
Add SetAttributes length check and ...
@rocky
Copy link
Member

rocky commented Nov 15, 2022

As i mentioned in another PR, let me suggest some code and you can review. Thanks.

@mmatera
Copy link
Contributor Author

mmatera commented Nov 15, 2022

Ok. This was just to illustrate the point.

@rocky
Copy link
Member

rocky commented Nov 15, 2022

Ok. This was just to illustrate the point.

Ok. My takeaway with this is that there is some misunderstanding.

@TiagoCavalcante
Copy link
Contributor

@mmatera just 2 Git tips:

  • to not make the Git history complicated with merge commits you can use git rebase branch_name instead of git merge branch_name
  • when things get complicated you can rewrite the history selecting only the commits you really want: git log, git checkout master, git checkout -b branch_name_new, and then for each commit you want to be in the branch branch_name do git cherry-pick commit_SHA, git branch -D branch_name, git branch -m branch_name and finally git push -f

@mmatera
Copy link
Contributor Author

mmatera commented Nov 15, 2022

@mmatera just 2 Git tips:

* to not make the Git history complicated with merge commits you can use `git rebase branch_name` instead of `git merge branch_name`

* when things get complicated you can rewrite the history selecting only the commits you really want: `git log`, `git checkout master`, `git checkout -b branch_name_new`, and then for each commit you want to be in the branch `branch_name` do `git cherry-pick commit_SHA`, `git branch -D branch_name`, `git branch -m branch_name` and finally `git push -f`

@TiagoCavalcante thanks, and sorry for the noise. In any case, my mistake here was to put this in a PR instead of just cite the branch in the parent PR. The aim of this was just to understand @rocky 's idea.

@mmatera mmatera closed this Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants