-
-
Notifications
You must be signed in to change notification settings - Fork 61
Add builtin just once #620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add builtin just once #620
Conversation
…ay from the conditional.
improving clarity in Builtin.contribute
Adding comments and tests for Assignment
symbols.py: system_symbols() -> symbol_set(); "systems_symbols" name is too close Symbol( System` to module systemsymbols. Also, we now require symbols as parameters), not strings. systemsymbols.py: more system symbols
It appears this was originally Pattern.create. I suspect due to bad modularity and a lack of understandig Python that an import could be added inside the routine, this static method got moved outside of the class. Later on, the modularity was fixed, but the hack persisted. These kinds of code smells side effects of poor communication.
wehn it gets fixed.
improve `OneIdentity` builtin
* More apply() -> eval() cutovers in the changed files * Some <dt> indentation regularization. * DRY redundant "argr" message definitions
Add SetAttributes length check and ...
As i mentioned in another PR, let me suggest some code and you can review. Thanks. |
Ok. This was just to illustrate the point. |
Ok. My takeaway with this is that there is some misunderstanding. |
@mmatera just 2 Git tips:
|
@TiagoCavalcante thanks, and sorry for the noise. In any case, my mistake here was to put this in a PR instead of just cite the branch in the parent PR. The aim of this was just to understand @rocky 's idea. |
This PR is one possible implementation for the @rocky 's idea that builtins (and autoload modules) should be loaded just once.