Skip to content

improving clarity in Builtin.contribute #600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 13, 2022
Merged

improving clarity in Builtin.contribute #600

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions mathics/builtin/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,15 +283,16 @@ def check_options(options_to_check, evaluation):
rules.append(
BuiltinRule(name, pattern, function, check_options, system=True)
)
for pattern, replace in self.rules.items():
if not isinstance(pattern, BaseElement):
pattern = pattern % {"name": name}
pattern = parse_builtin_rule(pattern, definition_class)
replace = replace % {"name": name}
# FIXME: Should system=True be system=not is_pymodule ?
rules.append(Rule(pattern, parse_builtin_rule(replace), system=True))
for pattern_str, replace_str in self.rules.items():
pattern_str = pattern_str % {"name": name}
pattern = parse_builtin_rule(pattern_str, definition_class)
replace_str = replace_str % {"name": name}
rules.append(
Rule(pattern, parse_builtin_rule(replace_str), system=not is_pymodule)
)

box_rules = []
# FIXME: Why a special case for System`MakeBoxes? Remove this
if name != "System`MakeBoxes":
new_rules = []
for rule in rules:
Expand Down