Adjustments for escape-sequence scanning changes #1403
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.github/workflows: CI testing needs to be doine with revise-escape-sequence-scanning branch
parser.py: next() needs to catch at least escape sequence errors. (Maybe
more?)
test_parser.py: we now give a more specific "NamedCharacterSyntaxError"
error
Comment out self.check("x \\\ny", "Times[x, y]") test until we
understand what the right behavior is. (Next time we'll document the
test better.)
TranslateError, TranslateErrorNew, ScanError are now all ScannerError
Use more direct and simpler error class name that is is more like its other subclassed errors.
rocky
commented
May 31, 2025
|
|
||
| def p_String(self, token: Token) -> String: | ||
| result = String(unescape_string(token.text)) | ||
| result = String(token.text[1:-1]) |
Member
Author
There was a problem hiding this comment.
Avoiding "unescape_string" probably addresses the warnings in testing we've been getting about invalid Python escape sequences.
I think the situation previously was that the scanner was relying on unescape_string to convert some escape strings rather than handed these in the scanner.
mmatera
reviewed
May 31, 2025
| self.check("x \\\ny", "Times[x, y]") | ||
|
|
||
| ## TODO see what this should do and why | ||
| ## self.check("x \\\ny", "Times[x, y]") |
Contributor
There was a problem hiding this comment.
Maybe this could be useful: in the console, WMA:
Syntax::sntxf: "x " cannot be followed by "\n y".
In[2]:= x *\n y
Syntax::sntxf: "x *" cannot be followed by "\n y".
In[3]:= x *
y
Out[3]= x y
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracks changes in scanner to handle escape sequences more correctly and to handle escaped boxing operators more properly.
Comment out self.check("x \\ny", "Times[x, y]") test until we understand what the right behavior is. (Next time we'll document the test better.)