Upgrade to Rust 1.87 #32653
Merged
Upgrade to Rust 1.87 #32653
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teskje
commented
Jun 4, 2025
| # in slower code due to the allocation. | ||
| ("large_enum_variant", 0), | ||
| # A specialization of `large_enum_variant`; similar arguments apply. | ||
| ("result_large_err", 0), |
Contributor
Author
There was a problem hiding this comment.
I actually think enabling this lint might be useful. But fixing all the instances it finds is a bunch of effort and I didn't want to block the fix for the std::sync::mpsc safety bug on it.
teskje
commented
Jun 4, 2025
petrosagg
approved these changes
Jun 4, 2025
Contributor
petrosagg
left a comment
petrosagg
left a comment
There was a problem hiding this comment.
LGTM! I'd wait for Ben to take a second a look on the persist changes
def-
approved these changes
Jun 4, 2025
Contributor
def-
left a comment
def-
left a comment
There was a problem hiding this comment.
Nightly triggered: https://buildkite.com/materialize/nightly/builds/12211
antiguru
approved these changes
Jun 4, 2025
teskje
force-pushed
the
rust-1.87
branch
2 times, most recently
from
3d7d64c to
f610ea6
Compare
ptravers
approved these changes
Jun 4, 2025
Contributor
Author
|
The build is failing due to what looks like llvm compatibility issues. I'll try updating our version of llvm as well. |
Contributor
Author
|
Upgrading clang fixed the build, but the Miri tests are broken because of taiki-e/portable-atomic#210. Trying again without upgrading the Nightly version. |
Contributor
Author
|
TFTRs! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades Materialize to use Rust 1.87
and a recent nightly, and fixes the resulting clippy lint errors.Note that Rust 1.87 is particularly exciting because it fixes the channel use-after-free bug that Petros found.
Motivation
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.