storage: fix shutdown token for copy to s3 sink #30887
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The COPY TO S3 sink must not flush files to S3 during shutdown, as those
files may only be partially written.
This can cause correctness issues when running copy operations on
multiprocess replicas, as the lagging replica's copy sink will get
dropped partway through.
Motivation
Tips for reviewer
This is essentially just a copy of #30844, but I didn't want to lose my in progress CI run over there.
Checklist
$T ⇔ Proto$T
mapping (possibly in a backwards-incompatible way), then it is tagged with aT-proto
label.