optimizer: hoist type knowledge into transform::normalize_lets #17769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our type system has an unexpected corner in that the Eq implementation is derived but has no type knowledge, which necessitates using something other than `==` when determining type interoperability, i.e. a function named `base_eq`. This patch fixes an instance of this in the optimizer, but probably warrants a more thorough investigation into where else it's used.
|
@sploiselle I've tried adding the derived disallowed-methods = [
# ...
{ path = "mz_repr::ScalarType::eq", reason = "use `ScalarType::base_eq` instead" },
] |
aalexandrov
approved these changes
Feb 22, 2023
aalexandrov
approved these changes
Feb 22, 2023
|
Thanks @sploiselle! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our type system has an unexpected corner in that the Eq implementation is derived but has no type knowledge, which necessitates using something other than
==when determining type interoperability, i.e. a function namedbase_eq.This patch fixes an instance of this in the optimizer, but probably warrants a more thorough investigation into where else it's used.
Motivation
This PR fixes a recognized bug. Fixes MaterializeInc/database-issues#5174
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way) and therefore is tagged with aT-protolabel.