Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump hyper from 0.14.20 to 0.14.23 #16005

Merged
merged 1 commit into from
Nov 10, 2022
Merged

Conversation

teskje
Copy link
Contributor

@teskje teskje commented Nov 10, 2022

This PR updates hyper, specifically to include the fix for this issue: hyperium/hyper#2649. My hope is that this solves MaterializeInc/database-issues#4616.

Motivation

  • This PR fixes a recognized bug.

Checklist

@teskje teskje marked this pull request as draft November 10, 2022 11:09
@teskje teskje marked this pull request as ready for review November 10, 2022 11:59
@teskje
Copy link
Contributor Author

teskje commented Nov 10, 2022

@philip-stoev Tests didn't flake the first time. Is there anything better we can do to check if this changes fixes the flake? Should we just merge and wait a day?

Copy link
Contributor

@philip-stoev philip-stoev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is a very rare flake, only seen once as far as I know. So no other option but to merge and wait .

@teskje teskje merged commit 9c189a4 into MaterializeInc:main Nov 10, 2022
@teskje teskje deleted the bump-hyper branch November 10, 2022 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants