New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wrong color space #14

Open

YouSafe wants to merge 1 commit into MatchaChoco010:main from YouSafe:fix-color-space

Contributor

YouSafe commented Apr 6, 2024

Since emilk/egui#2071 integrators of egui are prompted to do all color operations in gamma space. This PR achieves that by:

Changing the format of the texture_image to R8G8B8A8_SRGB
Removing the conversion of the colour in the vertex shader from srgb to linear
Applies a conversion of the texture sample back to gamma space (since shaders perform an automatic conversion to linear space if the sampled image is an SRGB image)

Before:

After:


          Fix wrong color space

f8887e1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet