New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Geometry::fromArray, add $srid parameter #117

Closed

ju-gow wants to merge 1 commit into MatanYadaev:master from ju-gow:patch-1

Contributor

ju-gow commented Apr 2, 2024

No description provided.


          Geometry::fromArray, add $srid parameter

950170f

Owner

MatanYadaev commented Apr 2, 2024

Thanks for the PR!

Can you add the relevant changes in the API.md?

And, please add 3 tests to PointTest.php:

creates point from array
creates point with SRID from array
throws exception when creating point from invalid array
These tests already exists for fromJson, you can copy and paste them and make the small changes to work with an array instead of a JSON string.

MatanYadaev closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet