Skip to content

enable/disable Guest Wifi#29

Closed
moranbf wants to merge 6 commits intoMatMaul:mainfrom
moranbf:master
Closed

enable/disable Guest Wifi#29
moranbf wants to merge 6 commits intoMatMaul:mainfrom
moranbf:master

Conversation

@moranbf
Copy link
Copy Markdown

@moranbf moranbf commented Feb 18, 2018

I copied some conde for enable_config and disable_config, but wrote code to disable and enable guest wifi. Where set_guest_wifi_enable(SSID,SSID_KEY) is probably limited to 16 characters at this point, but could be expanded to 63, I looks like they key is broken into 4 xml tags ..4. But I only coded for one.

@moranbf moranbf closed this Mar 23, 2018
@moranbf moranbf reopened this Mar 23, 2018
@moranbf
Copy link
Copy Markdown
Author

moranbf commented Mar 23, 2018

merge to master?

@MatMaul
Copy link
Copy Markdown
Owner

MatMaul commented Apr 18, 2018

Can you squash those commits in one with the same message as this PR title, and remove .idea/vcs.xml ? Thanks.

@moranbf
Copy link
Copy Markdown
Author

moranbf commented Apr 19, 2018 via email

@MatMaul
Copy link
Copy Markdown
Owner

MatMaul commented Apr 19, 2018

And please rebase and try to follow the pattern introduced in my refactor for the requests ;)

@MatMaul
Copy link
Copy Markdown
Owner

MatMaul commented Apr 19, 2018

And complete the README with the new public methods please.

@MatMaul
Copy link
Copy Markdown
Owner

MatMaul commented Apr 20, 2018

I just added a params parameter to _make_request to make your life easier :)
You can just pass a dict.
55cdd82

@starkillerOG
Copy link
Copy Markdown
Collaborator

I will close this PR since the new PR: #120 includes these features using the folowing functions:

netgear.set_2g_guest_access_enabled(True)
netgear.set_5g_guest_access_enabled(True)
netgear.get_2g_guest_access_enabled()
netgear.get_5g_guest_access_enabled()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants