Closed
Conversation
Author
|
merge to master? |
Owner
|
Can you squash those commits in one with the same message as this PR title, and remove .idea/vcs.xml ? Thanks. |
Author
|
Will do, might be a few days
…On Wed, Apr 18, 2018 at 2:28 PM, Mathieu Velten ***@***.***> wrote:
Can you squash those commits in one with the same message as this PR
title, and remove .idea/vcs.xml ? Thanks.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#29 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AP2nFSIbCAYW8KQJM1FAjCHg9ozj-GNCks5tp5PNgaJpZM4SJhC8>
.
|
Owner
|
And please rebase and try to follow the pattern introduced in my refactor for the requests ;) |
Owner
|
And complete the README with the new public methods please. |
Owner
|
I just added a |
Collaborator
|
I will close this PR since the new PR: #120 includes these features using the folowing functions: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I copied some conde for enable_config and disable_config, but wrote code to disable and enable guest wifi. Where set_guest_wifi_enable(SSID,SSID_KEY) is probably limited to 16 characters at this point, but could be expanded to 63, I looks like they key is broken into 4 xml tags ..4. But I only coded for one.