Update configuration of the desktop file #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, Thanks for the contribution. I'll merge and release it tomorrow 😄!
Not as much as you'd think! "HiFi" is grammatically correct, "hifi" is just me being lazy! |
|
Hey, it's strange, but these changes have not been reflected in the newest release (.deb file). Does it have to be changed somewhere else or do you cache some files? |
|
@BlueManCZ, I blame you! (just kidding) Apparently, I'm overwriting the desktop file for the .deb (and other) version(s) specifically: https://github.com/Mastermindzh/tidal-hifi/blob/master/build/electron-builder.deb.yml#L2 My best guess is due to the required "target" field. Sorry for the inconvenience. I might be able to fix it tonight though. |
|
Oh. That would explain the category being still Audio, but I don't see where the Name or GenericName is being overwritten, yet it still remains tidal-hifi. |
|
@BlueManCZ , I expect that you have to overwrite the entire desktop file there tbh. It probably takes the default if you don't (which would be tidal-hifi). I don't use the .deb (I use the AUR) so I didn't really test either. The .desktop file from the AUR is updated correctly but it's done AFTER electron-builder touches it. I will devote some time to fix this soon :) |
Mastermindzh
added a commit
that referenced
this pull request
Sep 25, 2022
* Pr dest (#166) * Update configuration of the desktop file (#165) * - Changed the category of the desktop file to AudioVideo - Changed desktop file name to "TIDAL Hi-Fi" Co-authored-by: Ivo Šmerek <[email protected]> * Redesign of the settings window * changed sass to scss, fixed color of switches and disabled rounded corners Co-authored-by: Rick van Lieshout <[email protected]>
Mastermindzh
added a commit
that referenced
this pull request
Sep 25, 2022
* Update configuration of the desktop file (#165) * - Changed the category of the desktop file to AudioVideo - Changed desktop file name to "TIDAL Hi-Fi" * Redesign of the settings window (#168) * Pr dest (#166) * Update configuration of the desktop file (#165) * - Changed the category of the desktop file to AudioVideo - Changed desktop file name to "TIDAL Hi-Fi" Co-authored-by: Ivo Šmerek <[email protected]> * Redesign of the settings window * changed sass to scss, fixed color of switches and disabled rounded corners Co-authored-by: Rick van Lieshout <[email protected]> * - icon is set to new static path based on Arch/Debian - Name has changed to Tidal-Hifi Co-authored-by: Ivo Šmerek <[email protected]>
Mastermindzh
added a commit
that referenced
this pull request
Oct 24, 2022
* Release of settings window and desktop file fixes (#169) * Update configuration of the desktop file (#165) * - Changed the category of the desktop file to AudioVideo - Changed desktop file name to "TIDAL Hi-Fi" * Redesign of the settings window (#168) * Pr dest (#166) * Update configuration of the desktop file (#165) * - Changed the category of the desktop file to AudioVideo - Changed desktop file name to "TIDAL Hi-Fi" Co-authored-by: Ivo Šmerek <[email protected]> * Redesign of the settings window * changed sass to scss, fixed color of switches and disabled rounded corners Co-authored-by: Rick van Lieshout <[email protected]> * - icon is set to new static path based on Arch/Debian - Name has changed to Tidal-Hifi Co-authored-by: Ivo Šmerek <[email protected]> * Disable background throttling (#171) * disable background throttling for consistent setInterval * add disable throttle as config option * 4.3.0 * Check if app is default protocol client before setting Co-authored-by: Rick van Lieshout <[email protected]> Co-authored-by: Ivo Šmerek <[email protected]> Co-authored-by: Cukmekerb <[email protected]> Co-authored-by: Brecht Yperman <[email protected]>
Mastermindzh
added a commit
that referenced
this pull request
Oct 24, 2022
* Update configuration of the desktop file (#165) * - Changed the category of the desktop file to AudioVideo - Changed desktop file name to "TIDAL Hi-Fi" * Redesign of the settings window (#168) * Pr dest (#166) * Update configuration of the desktop file (#165) * - Changed the category of the desktop file to AudioVideo - Changed desktop file name to "TIDAL Hi-Fi" Co-authored-by: Ivo Šmerek <[email protected]> * Redesign of the settings window * changed sass to scss, fixed color of switches and disabled rounded corners Co-authored-by: Rick van Lieshout <[email protected]> * - icon is set to new static path based on Arch/Debian - Name has changed to Tidal-Hifi * Check if app is default protocol client before setting (#178) * Release of settings window and desktop file fixes (#169) * Update configuration of the desktop file (#165) * - Changed the category of the desktop file to AudioVideo - Changed desktop file name to "TIDAL Hi-Fi" * Redesign of the settings window (#168) * Pr dest (#166) * Update configuration of the desktop file (#165) * - Changed the category of the desktop file to AudioVideo - Changed desktop file name to "TIDAL Hi-Fi" Co-authored-by: Ivo Šmerek <[email protected]> * Redesign of the settings window * changed sass to scss, fixed color of switches and disabled rounded corners Co-authored-by: Rick van Lieshout <[email protected]> * - icon is set to new static path based on Arch/Debian - Name has changed to Tidal-Hifi Co-authored-by: Ivo Šmerek <[email protected]> * Disable background throttling (#171) * disable background throttling for consistent setInterval * add disable throttle as config option * 4.3.0 * Check if app is default protocol client before setting Co-authored-by: Rick van Lieshout <[email protected]> Co-authored-by: Ivo Šmerek <[email protected]> Co-authored-by: Cukmekerb <[email protected]> Co-authored-by: Brecht Yperman <[email protected]> * docs Co-authored-by: Ivo Šmerek <[email protected]> Co-authored-by: Brecht Yperman <[email protected]> Co-authored-by: Cukmekerb <[email protected]> Co-authored-by: Brecht Yperman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Category change is based on the QA Notice from Gentoo package manager:
The desktop name change may be subjective, but application desktop names usually start with capitalized letters and divide words with spaces. Now it looks kind of weird between other applications. I thought either TIDAL, TIDAL Hi-Fi, Tidal or Tidal Hi-Fi could look nice.