Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pulls over a commit from #7 , because strings are not the fastpath. This one change makes a crazy amount of difference:
With absolute numbers, that's:
And the memory allocation:
So yeah, drop to zero allocs, plus a two order of magnitude speedup. I'll worry about optimizing the errors to not actually evaluate strings over in #7, but avoiding string evaluation is the single most important performance change we can make.