Update major.minor.patch version for 64bit ints #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update NewVersion to parse ints with a 64bit int size. Version's major, minor and patch fields are all int64 but NewVersion was parsing them with a 32bit bitsize, update this to 64bits. This is useful when the patch number is a timestamp in the format: yyMMddHHmmssSSS Add a test cases using 2147483648 (1 more than max 32bit int).
|
@zknill thanks for the contribution |
|
Version 1.4.0 has been released with the change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update NewVersion to parse ints with a 64bit int size.
Version's major, minor and patch fields are all int64 but NewVersion was
parsing them with a 32bit bitsize, update this to 64bits.
This is useful when the patch number is a timestamp in the format:
yyMMddHHmmssSSS which produces numbers like 171003153320169
Add a test cases using 2147483648 (1 more than max 32bit int).