Oauth2 Support #21
Open
Oauth2 Support #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initial Petstore
removing extra file
Adding Actions for Sonar and Build
Adding Actions for Sonar and Build
fixing initial issues for the documentation
…tion-java into feature/documentation-updates # Conflicts: # README.md # src/main/java/com/mastercard/app/petstore/PetstoreApplication.java # src/main/java/com/mastercard/app/petstore/examples/AdoptionFlowExample.java # src/main/java/com/mastercard/app/petstore/examples/EmployeeFlowExample.java # src/main/java/com/mastercard/app/petstore/examples/PetFlowExample.java
Create maven-test.yml
…tion-java into feature/documentation-updates
Create sonar.yml
…tion-java into feature/documentation-updates
Update README.md
updating client encryption
Various Updates
updating the petstore yaml
Updating yaml text and error codes. Removing unused field from pom
# Conflicts: # .github/workflows/sonar.yml # pom.xml # src/main/java/com/mastercard/app/petstore/PetstoreApplication.java # src/main/java/com/mastercard/app/petstore/configuration/Configuration.java # src/main/java/com/mastercard/app/petstore/services/EmployeeService.java # src/main/java/com/mastercard/app/petstore/utils/JweEncryptionUtils.java # src/main/resources/application.properties # src/main/resources/petstore.yaml # src/test/java/com/mastercard/app/petstore/EmployeeServiceTest.java
karen-avetisyan-mc
requested review from
danny-gallagher,
rfeelin,
NehaSony and
ShimonaR-MC
rfeelin
reviewed
Aug 26, 2025
NehaSony
reviewed
Aug 27, 2025
src/main/java/com/mastercard/app/petstore/utils/OAuth2Utils.java
Outdated
Show resolved
Hide resolved
src/main/java/com/mastercard/app/petstore/utils/OAuth2Utils.java
Outdated
Show resolved
Hide resolved
src/main/java/com/mastercard/app/petstore/utils/OAuth2Utils.java
Outdated
Show resolved
Hide resolved
src/main/java/com/mastercard/app/petstore/utils/OAuth2Utils.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Consider adding unit tests to verify that the constructor throws exceptions for missing/empty values, ensuring default values are reflected, and the client can create the object correctly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding OAuth 2.0 code