fix/513-cbor-x-type-issues #521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks correct to me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces use of the cbor-x dependency with tiny-cbor. The use of
cbor-x/index-no-evalcaused issues with transpiling typical Node-centric use of SimpleWebAuthn because TypeScript couldn't find types forindex-no-evaldue to the project's architecture.No reasonable workaround within SimpleWebAuthn could be determined so I have decided to move to the excellent tiny-cbor instead. This library supports the right amount of CBOR to work with WebAuthn responses, and also cross-publishes on https://deno.land/x and NPM, so it'll be a great replacement.
Addresses #513.