Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/460-track-browser-dom-ts #466

Merged
merged 5 commits into from
Oct 26, 2023
Merged

Conversation

MasterKale
Copy link
Owner

@MasterKale MasterKale commented Oct 26, 2023

This PR starts tracking packages/typescript-types/dom.ts so that the import from "./dom.ts" in index.ts can resolve in Deno projects.

And this file doesn't often need to be codegen'd, only when I update the version of TypeScript specified in the root package.json, so I won't codegen dom.ts on builds anymore.

To confirm the fix I ran the following and confirmed the deno vendor command succeeded:

$> cd scratchenv/460-deno-types-dom-ts
$> deno vendor ../../deno/server.ts --no-config --force
Vendored 101 modules into vendor/ directory.

To use vendored modules, specify the `--import-map vendor/import_map.json` flag when invoking Deno subcommands or add an `"importMap": "<path_to_vendored_import_map>"` entry to a deno.json file.

Fixes #460.

@MasterKale MasterKale added the package:types @simplewebauthn/typescript-types label Oct 26, 2023
@MasterKale MasterKale merged commit 499aec9 into master Oct 26, 2023
@MasterKale MasterKale deleted the fix/460-track-browser-dom-ts branch October 26, 2023 04:40
@MasterKale MasterKale added this to the v8.3.3 milestone Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:types @simplewebauthn/typescript-types
Projects
None yet
Development

Successfully merging this pull request may close these issues.

importing from deno.land fails caused by missing dep "src/dom.ts"
1 participant