fix/446-enforce-conditional-ui-autocomplete-token-order #451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MasterKale
changed the title
MasterKale
deleted the
fix/446-enforce-conditional-ui-autocomplete-token-order
branch
|
Thank you for providing such a simple library for Webauthn, I encounter a problem when using Web Components, since it using a shadow DOM, so the detection method |
|
@zhangbobell Please start a new Discussion about this, PR's are awful places for questions like yours to get a response. https://github.com/MasterKale/SimpleWebAuthn/discussions/new/choose |
|
@MasterKale OK, Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tweaks
startAuthentication()in browser to check that the"webauthn"value in an<input>'sautocompleteattribute is either the sole value or the last value. This aligns things with the WHATWG, which helps conditional UI appear more reliably in browsers that enforce autocomplete token order (i.e. Chrome.)Fixes #446.