feat/faster-cert-chain-validation #311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I accidentally discovered a fix for a performance bottleneck in certificate chain validation thanks to work done in #299. This should address #309. Based on some light testing via FIDO Conformance Tests, execution times seem to have gone down by around 10%. In one circumstance (unit tests) they decreased by as much as 60%.
Screenshots
Performance of groups of FIDO Metadata Conformance tests that took long enough to execute to get a "execution time flag" generally went down:
"tpm" - before
"tpm" - after
"android-safetynet" - before
"android-safetynet" - after
Metadata - before
Metadata - after