Fix/improve resident key registration options #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adjusts logic related to how the old
requireResidentKeyand newresidentKeyauthentication selection options influence what either is set to in the output fromgenerateRegistrationOptions():residentKeyis absent, then it will be set to"required"ifrequireResidentKeyis present andtruerequireResidentKeyis absent then it will be set to whether or notresidentKeyis set to"required"This should help implementers targeting L1 of the spec generate options that will trigger discoverable credential creation in environments targeting L2 of the spec as well.
Fixes #255