Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/mds-self-referencing #249

Merged
merged 2 commits into from
Aug 14, 2022
Merged

fix/mds-self-referencing #249

merged 2 commits into from
Aug 14, 2022

Conversation

MasterKale
Copy link
Owner

This PR adds support for self-referencing "packed" attestation statements. This should allow the library to pass the following test in FIDO Conformance Tools v1.7.2:

F-3 Send ServerAuthenticatorAttestationResponse with FULL "packed" attestation, with attStmt missing "x5c" field, and check that server returns an error

Screen Shot 2022-08-11 at 11 44 56 PM

Fixes #246

@MasterKale MasterKale merged commit 1a4e356 into master Aug 14, 2022
@MasterKale MasterKale deleted the fix/mds-self-referencing branch August 14, 2022 18:24
@MasterKale MasterKale added this to the v5.4.4 milestone Aug 15, 2022
@MasterKale MasterKale added the package:server @simplewebauthn/server label Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:server @simplewebauthn/server
Projects
None yet
1 participant