Return `AuthenticationExtensionsAuthenticatorOutputs` as part of registration and authentication #230

agektmr · 2022-07-21T03:05:49Z

This pull request:

Defines AuthenticationExtensionsAuthenticatorOutputs
Puts extensions in AuthenticatorData as part of output of verifyRegistrationResponse and verifyAuthenticationResponse.
Adds tests to parse extensions in AuthenticatorData in verifyRegistrationResponse and verifyAuthenticationResponse.

packages/server/src/helpers/decodeExtensions.ts

packages/server/src/registration/verifyRegistrationResponse.test.ts

packages/server/src/registration/verifyRegistrationResponse.ts

MasterKale · 2022-07-22T05:16:13Z

@agektmr Thank you for working on this! Just a few comments but otherwise this looks good.

- Rename `decodeExtensions` to `decodeAuthenticatorExtensions` - Mention authenticator extension - Include decoding in `parseAuthenticatorData` - Add tests for `decodeAuthenticatorExtensions`

- Change `extensions` to `extensionsData` and add `extensionsDataBuffer`

packages/server/src/helpers/decodeAuthenticatorExtensions.ts

Co-authored-by: Matthew Miller <[email protected]>

DevicePublicKeyJSON => DevicePublicKeyAuthenticatorOutput

packages/server/src/helpers/decodeAuthenticatorExtensions.ts

UvmJSON => UVMAuthenticatorOutput

packages/server/src/registration/verifyRegistrationResponse.ts

packages/server/src/helpers/decodeAuthenticatorExtensions.ts

- `decodeAuthenticatorExtensionData` => `decodeAuthenticatorExtensions` - `exentionsData` => `authenticatorExtensionResults` - Remove test case for malformed extension data

MasterKale

Thank you for enduring all of my feedback, this might just be the last round of it before we can merge this 🤩

packages/server/src/registration/verifyRegistrationResponse.ts

packages/server/src/authentication/verifyAuthenticationResponse.ts

packages/server/src/registration/verifyRegistrationResponse.ts

packages/server/src/helpers/parseAuthenticatorData.ts

- `authenticatorExtensionResults` => `extensionsData` - `authenticatorExtensionsDataBuffer` => `extensionsDataBuffer`

agektmr added 7 commits July 19, 2022 15:04

Temporary

152d00c

Temporary

68dbf51

Temporary

97f6423

Temporary working reg DPK impl

88d0352

DPK registration

58965f0

Add authentication extension output test

909eaa2

Use AuthenticationExtensionsAuthenticatorOutputs

7fdfa35

MasterKale requested changes Jul 22, 2022

View reviewed changes

agektmr added 2 commits July 22, 2022 15:35

Fixes to reflect comments

53dd14e

- Rename `decodeExtensions` to `decodeAuthenticatorExtensions` - Mention authenticator extension - Include decoding in `parseAuthenticatorData` - Add tests for `decodeAuthenticatorExtensions`

Fix for MasterKale#230

8cc0d0c

- Change `extensions` to `extensionsData` and add `extensionsDataBuffer`