Use dynamic model variables for timestamp column names #839
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@josephmancuso What do you think? Been waiting on this one for a while to finish out a PR in another repo. |
|
I seem to recall dynamic timestamp column names had been implemented at one point in the past, but I'm not totally sure... |
josephmancuso
approved these changes
Sep 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces hardcoded
"created_at"and"updated_at"timestamp column names with base model'sdate_created_atanddate_updated_atvariables. This allows configurability over which columns to use with the timestamps mixin. Besides, if we're already using these variables for date casting, we should also use them in the mixin.