Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Belongs to many - Table can't be without an underscore #825

Merged
merged 1 commit into from
Nov 7, 2022
Merged

fix: Belongs to many - Table can't be without an underscore #825

merged 1 commit into from
Nov 7, 2022

Conversation

maicol07
Copy link
Contributor

Fixes #803

josephmancuso
josephmancuso requested changes Oct 28, 2022
View reviewed changes
Copy link
Member

@josephmancuso josephmancuso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't work in the scenario that someone only specifies the first key right? like if someone specifies the self.local_key but not the self.foreign_key.

In that case i think it would overwrite whatever they specified as the self.local_key

@maicol07
Copy link
Contributor Author

maicol07 commented Oct 28, 2022 •
edited
Loading

This won't work in the scenario that someone only specifies the first key right? like if someone specifies the self.local_key but not the self.foreign_key.

In that case i think it would overwrite whatever they specified as the self.local_key

Why? Inside the elif there's the or that should keep the key id it's defined

@maicol07
Copy link
Contributor Author

maicol07 commented Nov 7, 2022

@josephmancuso ↑

@josephmancuso josephmancuso merged commit 325ec29 into MasoniteFramework:2.0 Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josephmancuso josephmancuso josephmancuso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Belongs to many - Table can't be without an underscore
2 participants
@maicol07 @josephmancuso