Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds oldest, latest methods to QueryBuilder, fixes #790 #795

Merged
merged 6 commits into from
Oct 25, 2022

Conversation

yubarajshrestha
Copy link
Contributor

@yubarajshrestha yubarajshrestha commented Sep 21, 2022

fixes #790

Copy link
Member

@josephmancuso josephmancuso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really like the order by raw solution here. If we do the order by raw it won't work with postgres or sql server

for field in fields:
    self.order_by(field, "desc")

@yubarajshrestha
Copy link
Contributor Author

I don't really like the order by raw solution here. If we do the order by raw it won't work with postgres or sql server

for field in fields:
    self.order_by(field, "desc")

Updated to order_by.

@BSN4
Copy link
Contributor

BSN4 commented Oct 8, 2022

tests?

@josephmancuso josephmancuso added the enhancement A feature that exists, works as intended but needs to be improved label Oct 8, 2022
Copy link
Member

@josephmancuso josephmancuso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks better but will need some tests to make me feel comfortable with it

@yubarajshrestha
Copy link
Contributor Author

This looks better but will need some tests to make me feel comfortable with it

Done

1 similar comment
@yubarajshrestha
Copy link
Contributor Author

This looks better but will need some tests to make me feel comfortable with it

Done

@yubarajshrestha yubarajshrestha requested review from josephmancuso and removed request for josephmancuso October 10, 2022 09:36
@josephmancuso josephmancuso merged commit fe9fff2 into MasoniteFramework:2.0 Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A feature that exists, works as intended but needs to be improved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add some methods
3 participants