Skip to content

Fixed JSON Cast should always return a string #754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

circulon
Copy link
Contributor

@circulon circulon commented Jul 8, 2022

This fixes the issue where a valid JSON string was not returned if the value being cast was a dict or list.
Added validation (as a valid JSON structure) of the value if it is a string

@josephmancuso josephmancuso merged commit e9425b2 into MasoniteFramework:2.0 Jul 9, 2022
@BSN4 BSN4 mentioned this pull request Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants