Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/682 #738

Merged
merged 2 commits into from
Jun 28, 2022
Merged

Feature/682 #738

merged 2 commits into from
Jun 28, 2022

Conversation

JRubics
Copy link
Contributor

@JRubics JRubics commented Jun 27, 2022 •
edited by josephmancuso
Loading

Fix new_from_builder using deepcopy but with fixing the infinite recursion

Fixes #682

@josephmancuso
Copy link
Member

ugh thanks for fixing this lol. Interesting fix I didn't know __setstate__ was a magic method like this. I have another issue where an object wasn't pickleable. Maybe using these magic methods will fix that issue too 🤔

@JRubics
Copy link
Contributor Author

JRubics commented Jun 28, 2022

I think it is at least worth trying and as I remember there was some magic method for pickling, but don't remember exactly how to use it 🙂

@josephmancuso josephmancuso merged commit 19ad422 into MasoniteFramework:2.0 Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

QueryBuilder created with new_from_builder() use the same references as the builder it is created from
2 participants
@JRubics @josephmancuso