Fixed string type casting/coercion from where_in methods
#650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josephmancuso
approved these changes
May 5, 2022
josephmancuso
changed the title
where_in methodswhere_in methods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Masonite should not cast args to strings when compiling SQL, or when checking if some data exists in a collection. Rather it should use the raw data that was passed (
where()already does this), and not make assumptions about what kind of data it is. Special cases should be handled manually, such as numeric strings matching integers.This allows for using data such as bytes objects as args to
where_inclauses, which will now correctly match against all database-supported data types.This may break some callers (that expect string coercion), so it should probably be considered backward-incompatible.