Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/637 - Fixed updating pivot table records on Many To Many relationships #649

Merged
merged 3 commits into from
May 5, 2022
Merged

Fix/637 - Fixed updating pivot table records on Many To Many relationships #649

merged 3 commits into from
May 5, 2022

Conversation

federicoparroni
Copy link
Contributor

No description provided.

@federicoparroni federicoparroni mentioned this pull request May 2, 2022
Closed
josephmancuso
josephmancuso requested changes May 2, 2022
View reviewed changes
Copy link
Member

@josephmancuso josephmancuso left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even though you couldn't replicate it. Should do the same thing to the apply_query method. I think that gets called when you eager load?

@federicoparroni
Copy link
Contributor Author

Yes, I can add it to the apply_query method too. In the meanwhile, could you please add some tests to cover also this cases?

@federicoparroni
Copy link
Contributor Author

@josephmancuso fixed also the apply_query method

@federicoparroni
Copy link
Contributor Author

@josephmancuso hello! Do you think that this PR can be merged?

@josephmancuso
Copy link
Member

@federicoparroni yes it looks good. I couldn't get to this yesterday and just want to test this out before merging it. But the code review looks good 👍

@josephmancuso josephmancuso changed the title Fix/637 Fix/637 - Cannot update pivot table records on Many To Many relationships May 4, 2022
@josephmancuso josephmancuso changed the title Fix/637 - Cannot update pivot table records on Many To Many relationships Fix/637 - Fixed updating pivot table records on Many To Many relationships May 4, 2022
@federicoparroni
Copy link
Contributor Author

@josephmancuso thank you so much for everything you did!

@josephmancuso josephmancuso merged commit 906bcef into MasoniteFramework:2.0 May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josephmancuso josephmancuso josephmancuso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@federicoparroni @josephmancuso