Fixed loading cookies on Linux environments #703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josephmancuso
changed the title
|
how was this PR open? Its not running any of the tests for some reason |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I came across this issue which I could not explain, but my best guess is it's got something to do with the Linux,
where the
self.environ.get("HTTP_COOKIE", "")returns the cookie_string which is delimited with ";" whereas on my local Mac environment it returns the cookie_string which is delimited with "; " which creates an issue where the API calls fail as the CSRF tokens doesn't match.The solution provided in the PR is a better way to handle cookies it's inspired by how Django & Laravel handles cookies and should work for both scenarios.