Fix deprecation warning for distutils module in craft auth command
#563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #562.
Old
copy_treemethod doc:https://docs.python.org/3/distutils/apiref.html#distutils.dir_util.copy_tree
New
copytreemethod doc:https://docs.python.org/3/library/shutil.html#shutil.copytree
The new method will complain if directory already exists when the old method was not complaining. To keep same behaviour we need to add,
dirs_exists_ok=Trueargument to allow overriding. But this option is only available starting from Python 3.8. As Masonite is compatible with Python 3.7, we need to handle this case (this switch will be removed when 3.7 will be dropped by Masonite one day).I am not a big fan of switches but here it's not that much of a problem IMO.