Add PID settings for the z axis (take two) #747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Strange behavior when trying to go back to default settings
|
Congratulations on the pull request @BarbourSmith Now we need to decide as a community if we want to integrate these changes. Vote by giving this comment a thumbs up or a thumbs down. Votes are counted in 48 hours. Ties will not be merged. I'm just a robot, but I love to see people contributing so I'm going vote thumbs up! |
|
Time is up and we're ready to merge this pull request. Great work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds advanced settings options for independently setting the PID values for the z-axis. As near as I can tell it is working with the exception that settings are only pushed to the machine when the switch from using the default values to using custom values is switched, however this is the case for all the custom PID value settings not just the z-axis ones and was the case before this pull request so it seems like a separate issue.
The issue is caused by line 191 in
main.pyelif key == 'enablePosPIDValues':Which only computes the new values when the switch changes position.