Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing language in calibration process #785

Open
guidobender opened this issue Jan 20, 2019 · 7 comments
Open

Changing language in calibration process #785

guidobender opened this issue Jan 20, 2019 · 7 comments

Comments

@guidobender
Copy link

Hi,
I ran into some confusion when calibrating with the 1.26 ground control and triangular sled. I would like to suggest changing some of the wording to increase clarity.
Please let me know if you have questions.
Thanks
Tschöhö
Superbender

Current language of step to adjust chain length after motor-to-motor distance measurement:

Now we are going to adjust the chains to a known length.

If your chains are not attached place the first link of the chain on the vertical sprocket tooth.
If your chains are already in place they may retract to the target length.

The correct length of first the left and then the right chain will be measured out.
…(more text)

Text that I would suggest:

If your chains are already in place they may retract to the target length.

If your left chain is still attached to the right motor from the length measurement motor-to-motor, remove it from the right motor without changing the position it has on the left motor.

For chains that are not attached to a motor (typical calibration = right chain) place the first link of the chain on the vertical sprocket tooth.

…(more text)

@BarbourSmith
Copy link
Member

That is an excellent idea. Thank you for giving me exact wording for what to change I will create a pull request to propose the change

BarbourSmith added a commit that referenced this issue Jan 21, 2019
Update the wording of the adjust chain lengths calibration step as proposed in #785
@BarbourSmith
Copy link
Member

I created #786 to add the change. Let me know what you think, and give it a 👍 once the robot comments if it looks good

@GeroBH
Copy link
Contributor

GeroBH commented Jan 21, 2019 via email

@BarbourSmith
Copy link
Member

@GeroBH I agree. Having an updated picture is a good idea. Unfortunately I am not in a position to take one right away, but I will keep it on my todo list. Does anyone else have a good picture with the sled centered that we could use there?

@guidobender
Copy link
Author

Below are a couple of images from my machine. I hope that helps.
I have another suggestion regarding the calibration. Will open another issue shortly.
Very cool to collaborate in this way. You guys rock.

img_4026
img_4025

@GeroBH
Copy link
Contributor

GeroBH commented Feb 13, 2019

merged commit c79e67d into master 13 days ago
So can be closed?

@BarbourSmith
Copy link
Member

I vote to close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants