Random changes. #6
Conversation
src/import_pipeline.cc
Outdated
| IndexUpdate dummy; | ||
| dummy.file_id = -1; // trigger refresh semantic highlight | ||
| queue->on_indexed.PushBack( | ||
| Index_OnIndexed(std::move(dummy), PerformanceImportFile()), false); |
There was a problem hiding this comment.
How about?
struct IndexUpdate {
...
int file_id = -1;
...Index_OnIndexed(IndexUpdate{}, PerformanceImportFile())
| @@ -216,6 +224,18 @@ void QueryDb_OnIndexed(QueueManager* queue, | |||
| SemanticHighlightSymbolCache* semantic_cache, | |||
| WorkingFiles* working_files, | |||
| Index_OnIndexed* response) { | |||
|
|
|||
| if (response->update.file_id < 0) { // dummy | |||
There was a problem hiding this comment.
Semantic highlighting does work reliably when the project is still loading. This is because message_handler.cc uses:
switch (sym.kind) {
case SymbolKind::Func: {
const QueryFunc& func = db->GetFunc(sym);
const QueryFunc::Def* def = func.AnyDef(); ///////// definition required, declaration is ignored
if (!def)
continue; // applies to for loopFunctions defined outside of the current file may not be colored correctly.
I think this patch is very promising to improve the situation!
I occasionally observe that some files are not highlighted, but I am unable to narrow it down (does not look like a forward-line out-of-range error)
I'll try this patch tomorrow on LLVM
| @@ -106,8 +106,8 @@ void IncludeComplete::Rescan() { | |||
| SetThreadName("scan_includes"); | |||
| Timer timer; | |||
|
|
|||
| InsertIncludesFromDirectory(g_config->projectRoot, | |||
| false /*use_angle_brackets*/); | |||
| // InsertIncludesFromDirectory(g_config->projectRoot, | |||
There was a problem hiding this comment.
This can just be removed. (I didn't even notice this because I don't use include completion much)
| g_config->index.threads = | ||
| std::max(int(std::thread::hardware_concurrency() * 0.8), 1); | ||
| } | ||
| if (g_config->index.threads == 0) |
| @@ -563,6 +563,9 @@ void Project::Index(QueueManager* queue, | |||
| queue->index_request.PushBack(Index_Request(entry.filename, entry.args, | |||
| is_interactive, *content, id)); | |||
| }); | |||
| // dummy request to indicate that project is loaded and | |||
| SetTypeName(ns, referenced, nullptr, name.c_str(), param); | ||
| CXFile referenced_file; | ||
| Range spell = referenced.get_spell(&referenced_file); | ||
| if (file == referenced_file) { |
There was a problem hiding this comment.
what problem does this check solve?
There was a problem hiding this comment.
I think this should fix wrong spell name highlight for aliased namespace. For example, namespace fs = std::experimental::filesystem in filesystem.hh. 7:11-7:13 are also highlighted in other files.
|
Persistency + concurrency + dependency tracking + single-versioned preamble is a very tricky problem. I hope my recent simplification (refactor) to import_pipeline.cc makes it much easier to reason about. If you are interested, https://www.zhihu.com/question/276181325 |
|
刪除增量更新一是對於大部分檔案沒什麼用(uses中行列號都要變化，只對尾部的修改有一點小作用，減輕主執行緒負擔；索引執行緒要寫索引到磁碟，沒有優化可言)；二是對於檔案頻繁保存的使用場景，不完全更新更容易產生引用重複/丟失問題。 我把timestamp_manager刪掉也是爲了簡化考慮(clang內部必然大量檔案系統stat，libclang下游節省一點stat沒太大意義)。cache_manager幾乎刪掉是覺得這明顯增大了data race的可能 另外就是src/下細碎檔案實在太多了。看不慣 😾 |
|
In case you haven't watched it yet https://www.youtube.com/watch?v=BvjrZ3QioBI It would be wonderful if two language servers can be used together, ccls for indexing (it is almost certain that they could not do it in a memory efficient manner) and clangd for completion (global completion is a nice feature) 立志好好學習clang，我早晚得用Clang C++重寫這個libclang indexer |
Refresh semantic highlight for all working files after loading the project.