Fix active-pane border rendered too far below the pane's top - #4

Merged

MarvinZeising merged 1 commit into

fix/pane-border-offset

Aug 3, 2026

MarvinZeising commented Aug 3, 2026

Owner

Re-lands 40bcdc1e8a, which was committed straight onto marvin-main on Aug 1 but lost the same night: build-and-install.sh used to run git checkout -B marvin-main origin/marvin-main on every rebuild, force-resetting the local branch to origin and silently discarding this never-pushed commit. It only survived on an orphaned local scratch branch. Opening as a real PR this time so it can't be lost again.

Single-tab panes hide their tab strip, so their real content starts higher than the chrome-trimmed layout estimate assumed -- which made the active-pane border (and unread/flash rings) render ~2 rows below the pane's true top edge.


          Fix active-pane border rendered too far below the pane's top

preferredTmuxWorkspacePaneWindowOverlayRect() validated the live ("exact")
pane rect against the chrome-trimmed layout estimate, which assumes every
pane's tab-strip chrome is topChromeHeight (28pt, ~2 terminal rows) tall.
Single-tab panes hide that tab strip, so their real content starts right at
the pane's top -- higher than the trimmed estimate -- which made the check
reject the accurate exact rect and fall back to the over-trimmed one,
rendering the active-pane border (and unread/flash rings) ~2 rows below the
pane's true top edge.

Add TmuxPaneOverlayGeometry.rawWindowOverlayRect(), an untrimmed variant of
windowOverlayRect(), and validate the exact rect against it instead.

MarvinZeising merged commit b443327 into marvin

MarvinZeising mentioned this pull request

sync-upstream.yml: stop resetting marvin from scratch every night #5

Merged

MarvinZeising added a commit that referenced this pull request


          Add nightly upstream/PR sync workflow (#4)

60668d7

MarvinZeising added a commit that referenced this pull request


          Add nightly upstream/PR sync workflow (#4)

eaa6197

MarvinZeising added a commit that referenced this pull request


          Fix active-pane border rendered too far below the pane's top (#4)

2794e03

preferredTmuxWorkspacePaneWindowOverlayRect() validated the live ("exact")
pane rect against the chrome-trimmed layout estimate, which assumes every
pane's tab-strip chrome is topChromeHeight (28pt, ~2 terminal rows) tall.
Single-tab panes hide that tab strip, so their real content starts right at
the pane's top -- higher than the trimmed estimate -- which made the check
reject the accurate exact rect and fall back to the over-trimmed one,
rendering the active-pane border (and unread/flash rings) ~2 rows below the
pane's true top edge.

Add TmuxPaneOverlayGeometry.rawWindowOverlayRect(), an untrimmed variant of
windowOverlayRect(), and validate the exact rect against it instead.

MarvinZeising added a commit that referenced this pull request


          Add nightly upstream/PR sync workflow (#4)

99a4601

MarvinZeising added a commit that referenced this pull request


          Add nightly upstream/PR sync workflow (#4)

d83f265

MarvinZeising added a commit that referenced this pull request


          Fix active-pane border rendered too far below the pane's top (#4)

971e463

preferredTmuxWorkspacePaneWindowOverlayRect() validated the live ("exact")
pane rect against the chrome-trimmed layout estimate, which assumes every
pane's tab-strip chrome is topChromeHeight (28pt, ~2 terminal rows) tall.
Single-tab panes hide that tab strip, so their real content starts right at
the pane's top -- higher than the trimmed estimate -- which made the check
reject the accurate exact rect and fall back to the over-trimmed one,
rendering the active-pane border (and unread/flash rings) ~2 rows below the
pane's true top edge.

Add TmuxPaneOverlayGeometry.rawWindowOverlayRect(), an untrimmed variant of
windowOverlayRect(), and validate the exact rect against it instead.

MarvinZeising mentioned this pull request

Fix active-pane border offset for agent session panes in splits #7

Merged

MarvinZeising added a commit that referenced this pull request


          Fix active-pane border offset for agent session panes in splits (#7)

f877dc1

tmuxWorkspacePaneExactRect's panel-type switch only handled
TerminalPanel and BrowserPanel; every other panel type (notably
AgentSessionPanel) fell to the default nil case, so the exact-rect
correction from #4 never applied and the active-pane border in a
split still used the chrome-trimmed estimate, reproducing the same
~2-row offset #4 fixed for terminals.

Expose hostedView on AgentSessionPanel (forwarding through
AgentSessionWebRendererSession to the bound WKWebView), matching the
existing hostedView/webView pattern on TerminalPanel/BrowserPanel, and
add it to the switch.

MarvinZeising added a commit that referenced this pull request


          Add nightly upstream/PR sync workflow (#4)

e0936f6

MarvinZeising added a commit that referenced this pull request


          Add nightly upstream/PR sync workflow (#4)

5bfd5cb

MarvinZeising added a commit that referenced this pull request


          Fix active-pane border rendered too far below the pane's top (#4)

8fbc321

preferredTmuxWorkspacePaneWindowOverlayRect() validated the live ("exact")
pane rect against the chrome-trimmed layout estimate, which assumes every
pane's tab-strip chrome is topChromeHeight (28pt, ~2 terminal rows) tall.
Single-tab panes hide that tab strip, so their real content starts right at
the pane's top -- higher than the trimmed estimate -- which made the check
reject the accurate exact rect and fall back to the over-trimmed one,
rendering the active-pane border (and unread/flash rings) ~2 rows below the
pane's true top edge.

Add TmuxPaneOverlayGeometry.rawWindowOverlayRect(), an untrimmed variant of
windowOverlayRect(), and validate the exact rect against it instead.

MarvinZeising added a commit that referenced this pull request


          Fix active-pane border offset for agent session panes in splits (#7)

89c3f45

tmuxWorkspacePaneExactRect's panel-type switch only handled
TerminalPanel and BrowserPanel; every other panel type (notably
AgentSessionPanel) fell to the default nil case, so the exact-rect
correction from #4 never applied and the active-pane border in a
split still used the chrome-trimmed estimate, reproducing the same
~2-row offset #4 fixed for terminals.

Expose hostedView on AgentSessionPanel (forwarding through
AgentSessionWebRendererSession to the bound WKWebView), matching the
existing hostedView/webView pattern on TerminalPanel/BrowserPanel, and
add it to the switch.

MarvinZeising added a commit that referenced this pull request


          Add nightly upstream/PR sync workflow (#4)

f976fed

MarvinZeising added a commit that referenced this pull request


          Add nightly upstream/PR sync workflow (#4)

8f6c3ae

MarvinZeising added a commit that referenced this pull request


          Fix active-pane border rendered too far below the pane's top (#4)

b69ceac

preferredTmuxWorkspacePaneWindowOverlayRect() validated the live ("exact")
pane rect against the chrome-trimmed layout estimate, which assumes every
pane's tab-strip chrome is topChromeHeight (28pt, ~2 terminal rows) tall.
Single-tab panes hide that tab strip, so their real content starts right at
the pane's top -- higher than the trimmed estimate -- which made the check
reject the accurate exact rect and fall back to the over-trimmed one,
rendering the active-pane border (and unread/flash rings) ~2 rows below the
pane's true top edge.

Add TmuxPaneOverlayGeometry.rawWindowOverlayRect(), an untrimmed variant of
windowOverlayRect(), and validate the exact rect against it instead.

MarvinZeising added a commit that referenced this pull request


          Fix active-pane border offset for agent session panes in splits (#7)

10cb91c

tmuxWorkspacePaneExactRect's panel-type switch only handled
TerminalPanel and BrowserPanel; every other panel type (notably
AgentSessionPanel) fell to the default nil case, so the exact-rect
correction from #4 never applied and the active-pane border in a
split still used the chrome-trimmed estimate, reproducing the same
~2-row offset #4 fixed for terminals.

Expose hostedView on AgentSessionPanel (forwarding through
AgentSessionWebRendererSession to the bound WKWebView), matching the
existing hostedView/webView pattern on TerminalPanel/BrowserPanel, and
add it to the switch.

MarvinZeising added a commit that referenced this pull request


          Add nightly upstream/PR sync workflow (#4)

bf9b3e2

MarvinZeising added a commit that referenced this pull request


          Add nightly upstream/PR sync workflow (#4)

250e8c3

MarvinZeising added a commit that referenced this pull request


          Fix active-pane border rendered too far below the pane's top (#4)

70f2774

preferredTmuxWorkspacePaneWindowOverlayRect() validated the live ("exact")
pane rect against the chrome-trimmed layout estimate, which assumes every
pane's tab-strip chrome is topChromeHeight (28pt, ~2 terminal rows) tall.
Single-tab panes hide that tab strip, so their real content starts right at
the pane's top -- higher than the trimmed estimate -- which made the check
reject the accurate exact rect and fall back to the over-trimmed one,
rendering the active-pane border (and unread/flash rings) ~2 rows below the
pane's true top edge.

Add TmuxPaneOverlayGeometry.rawWindowOverlayRect(), an untrimmed variant of
windowOverlayRect(), and validate the exact rect against it instead.

MarvinZeising added a commit that referenced this pull request


          Fix active-pane border offset for agent session panes in splits (#7)

90b7d03

tmuxWorkspacePaneExactRect's panel-type switch only handled
TerminalPanel and BrowserPanel; every other panel type (notably
AgentSessionPanel) fell to the default nil case, so the exact-rect
correction from #4 never applied and the active-pane border in a
split still used the chrome-trimmed estimate, reproducing the same
~2-row offset #4 fixed for terminals.

Expose hostedView on AgentSessionPanel (forwarding through
AgentSessionWebRendererSession to the bound WKWebView), matching the
existing hostedView/webView pattern on TerminalPanel/BrowserPanel, and
add it to the switch.

MarvinZeising added a commit that referenced this pull request


          Add nightly upstream/PR sync workflow (#4)

5e46d57

MarvinZeising added a commit that referenced this pull request


          Add nightly upstream/PR sync workflow (#4)

00c8883

MarvinZeising added a commit that referenced this pull request


          Fix active-pane border rendered too far below the pane's top (#4)

2e3292f

preferredTmuxWorkspacePaneWindowOverlayRect() validated the live ("exact")
pane rect against the chrome-trimmed layout estimate, which assumes every
pane's tab-strip chrome is topChromeHeight (28pt, ~2 terminal rows) tall.
Single-tab panes hide that tab strip, so their real content starts right at
the pane's top -- higher than the trimmed estimate -- which made the check
reject the accurate exact rect and fall back to the over-trimmed one,
rendering the active-pane border (and unread/flash rings) ~2 rows below the
pane's true top edge.

Add TmuxPaneOverlayGeometry.rawWindowOverlayRect(), an untrimmed variant of
windowOverlayRect(), and validate the exact rect against it instead.

MarvinZeising added a commit that referenced this pull request


          Fix active-pane border offset for agent session panes in splits (#7)

c8a656e

tmuxWorkspacePaneExactRect's panel-type switch only handled
TerminalPanel and BrowserPanel; every other panel type (notably
AgentSessionPanel) fell to the default nil case, so the exact-rect
correction from #4 never applied and the active-pane border in a
split still used the chrome-trimmed estimate, reproducing the same
~2-row offset #4 fixed for terminals.

Expose hostedView on AgentSessionPanel (forwarding through
AgentSessionWebRendererSession to the bound WKWebView), matching the
existing hostedView/webView pattern on TerminalPanel/BrowserPanel, and
add it to the switch.

MarvinZeising added a commit that referenced this pull request


          Add nightly upstream/PR sync workflow (#4)

9bfbbf0

MarvinZeising added a commit that referenced this pull request


          Add nightly upstream/PR sync workflow (#4)

a8f45f7

MarvinZeising added a commit that referenced this pull request


          Fix active-pane border rendered too far below the pane's top (#4)

cc245c7

preferredTmuxWorkspacePaneWindowOverlayRect() validated the live ("exact")
pane rect against the chrome-trimmed layout estimate, which assumes every
pane's tab-strip chrome is topChromeHeight (28pt, ~2 terminal rows) tall.
Single-tab panes hide that tab strip, so their real content starts right at
the pane's top -- higher than the trimmed estimate -- which made the check
reject the accurate exact rect and fall back to the over-trimmed one,
rendering the active-pane border (and unread/flash rings) ~2 rows below the
pane's true top edge.

Add TmuxPaneOverlayGeometry.rawWindowOverlayRect(), an untrimmed variant of
windowOverlayRect(), and validate the exact rect against it instead.

MarvinZeising added a commit that referenced this pull request


          Add nightly upstream/PR sync workflow (#4)

339cb46

MarvinZeising added a commit that referenced this pull request


          Add nightly upstream/PR sync workflow (#4)

6c42ea2

MarvinZeising added a commit that referenced this pull request


          Add nightly upstream/PR sync workflow (#4)

a4b6758

MarvinZeising added a commit that referenced this pull request


          Add nightly upstream/PR sync workflow (#4)

MarvinZeising added a commit that referenced this pull request


          Add nightly upstream/PR sync workflow (#4)

5f5da04

MarvinZeising added a commit that referenced this pull request


          Add nightly upstream/PR sync workflow (#4)

2bf8456

MarvinZeising added a commit that referenced this pull request


          Add nightly upstream/PR sync workflow (#4)

758e1e5

MarvinZeising added a commit that referenced this pull request


          Add nightly upstream/PR sync workflow (#4)

bfbb760

MarvinZeising added a commit that referenced this pull request


          Add nightly upstream/PR sync workflow (#4)

cbb2f2a

MarvinZeising added a commit that referenced this pull request


          Add nightly upstream/PR sync workflow (#4)

507a3b1

MarvinZeising added a commit that referenced this pull request


          Add nightly upstream/PR sync workflow (#4)

8c8880a

MarvinZeising added a commit that referenced this pull request


          Add nightly upstream/PR sync workflow (#4)

78733e6

MarvinZeising added a commit that referenced this pull request


          Add nightly upstream/PR sync workflow (#4)

cd1abec

MarvinZeising added a commit that referenced this pull request


          Add nightly upstream/PR sync workflow (#4)

e4ce967

MarvinZeising added a commit that referenced this pull request


          Add nightly upstream/PR sync workflow (#4)

2ac5d3f

MarvinZeising added a commit that referenced this pull request


          Add nightly upstream/PR sync workflow (#4)

aa6ac5d

MarvinZeising added a commit that referenced this pull request


          Add nightly upstream/PR sync workflow (#4)

27e10c7

MarvinZeising added a commit that referenced this pull request


          Add nightly upstream/PR sync workflow (#4)

4b9ec1b

MarvinZeising added a commit that referenced this pull request


          Add nightly upstream/PR sync workflow (#4)

c0adcf7

MarvinZeising added a commit that referenced this pull request


          Add nightly upstream/PR sync workflow (#4)

8fe29e0

MarvinZeising added a commit that referenced this pull request


          Add nightly upstream/PR sync workflow (#4)

cbaec12

MarvinZeising added a commit that referenced this pull request


          Add nightly upstream/PR sync workflow (#4)

ec712b6

MarvinZeising added a commit that referenced this pull request


          Add nightly upstream/PR sync workflow (#4)

8dc8203

MarvinZeising added a commit that referenced this pull request


          Add nightly upstream/PR sync workflow (#4)

46565e5

MarvinZeising added a commit that referenced this pull request


          Add nightly upstream/PR sync workflow (#4)

37bd712

MarvinZeising added a commit that referenced this pull request


          Add nightly upstream/PR sync workflow (#4)

db8e282

MarvinZeising added a commit that referenced this pull request


          Add nightly upstream/PR sync workflow (#4)

95960b0

MarvinZeising added a commit that referenced this pull request


          Add nightly upstream/PR sync workflow (#4)

b674957

MarvinZeising added a commit that referenced this pull request


          Add nightly upstream/PR sync workflow (#4)

c5d62f1

MarvinZeising added a commit that referenced this pull request


          Add nightly upstream/PR sync workflow (#4)

83a9bea

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet