Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add getters for setters in configuration.go #182

Merged
merged 3 commits into from
Oct 5, 2022

Conversation

atlekbai
Copy link
Contributor

@atlekbai atlekbai commented Oct 4, 2022

Added getters for settings in configuration.go:

func GetColorsEnabled() bool
func GetLineNumbersEnabled() bool
func GetRandomSeed() int64
func GetShowStartupMessage() bool
func GetDiffContextLines() int

closes #111

configuration.go Outdated Show resolved Hide resolved
@danieltiman666
Copy link

danieltiman666 commented Oct 4, 2022 via email

@codecov
Copy link

codecov bot commented Oct 5, 2022

Codecov Report

Base: 86.84% // Head: 87.02% // Increases project coverage by +0.17% 🎉

Coverage data is based on head (e2913c8) compared to base (b2fec78).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #182      +/-   ##
==========================================
+ Coverage   86.84%   87.02%   +0.17%     
==========================================
  Files          10       10              
  Lines         730      740      +10     
==========================================
+ Hits          634      644      +10     
  Misses         58       58              
  Partials       38       38              
Impacted Files Coverage Δ
configuration.go 74.35% <100.00%> (+3.77%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@atlekbai
Copy link
Contributor Author

atlekbai commented Oct 5, 2022

@MarvinJWendt waiting for the review :)

Copy link
Owner

@MarvinJWendt MarvinJWendt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for contributing 🚀

@MarvinJWendt MarvinJWendt merged commit b546627 into MarvinJWendt:main Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add GetXxx functions for settings
3 participants