-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add getters for setters in configuration.go #182
Add getters for setters in configuration.go #182
Conversation
I don't understand how anything works
…On Tue, 4 Oct 2022, 17:54 Tlekbai Ali, ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In configuration.go
<#182 (comment)>:
> + initSync.Lock()
+ defer initSync.Unlock()
Hello! I am using the locks, since the value can be changed on runtime.
Basically, I was orienting on the setters, since they were using locks too.
—
Reply to this email directly, view it on GitHub
<#182 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A3IN4NKXZH2KTSDBPHGHAEDWBROKPANCNFSM6AAAAAAQ4WNFOQ>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Codecov ReportBase: 86.84% // Head: 87.02% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #182 +/- ##
==========================================
+ Coverage 86.84% 87.02% +0.17%
==========================================
Files 10 10
Lines 730 740 +10
==========================================
+ Hits 634 644 +10
Misses 58 58
Partials 38 38
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
@MarvinJWendt waiting for the review :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for contributing 🚀
Added getters for settings in
configuration.go
:closes #111