Support node 12.x and refactor to use napi #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @MarshallOfSound Can we get this merged? |
|
@Superjo149 shall we fork the repo and continue from there ? |
|
@Superjo149 Thanks for your work. I didn't realise we were using your fork already before I created this issue. Do you have any ideas? I tried some stuff in my fork already, but no luck yet. |
|
@koenoe I am now only circling back to this. Electron 10 did not exist back then, hence why you were probably running into other issues. But it seems you already fixed it as I am now using your fork.😛 Thanks for that. |
|
Hi @koenoe and @MarshallOfSound , I'm trying to add this to Soundcleod but getting |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were some issues with older node versions where methods were deprecated in the native modules. I fixed these and decided to move it to napi since it's stable now.
This means we can now support newer electron versions. 🎉