[1.1.x] Wait for bed heaters between probing#9890
Merged
thinkyhead merged 2 commits intoMarlinFirmware:bugfix-1.1.xfrom Apr 21, 2018
Merged
[1.1.x] Wait for bed heaters between probing#9890thinkyhead merged 2 commits intoMarlinFirmware:bugfix-1.1.xfrom
thinkyhead merged 2 commits intoMarlinFirmware:bugfix-1.1.xfrom
Conversation
Author
|
Hrm this causes some communication errors. I believe the serial communication is causing it. What's the best way to notify the user? |
thinkyhead
reviewed
Mar 3, 2018
Marlin/Marlin_main.cpp
Outdated
Member
There was a problem hiding this comment.
See if SERIAL_ECHOLNPGM works better.
thinkyhead
reviewed
Mar 3, 2018
Marlin/Configuration.h
Outdated
Member
There was a problem hiding this comment.
Tabs are verboten. See if you can set your vim / notepad++ / etc. settings to use two spaces instead of tabs.
thinkyhead
force-pushed
the
bugfix-1.1.x
branch
5 times, most recently
from
5a75a1b to
b0abce5
Compare
thinkyhead
force-pushed
the
bugfix-1.1.x
branch
4 times, most recently
from
53f0c75 to
29b0488
Compare
thinkyhead
force-pushed
the
bugfix-1.1.x
branch
7 times, most recently
from
b8b1a22 to
fa3c14f
Compare
thinkyhead
force-pushed
the
bugfix-1.1.x
branch
3 times, most recently
from
0bebc14 to
0c1be96
Compare
thinkyhead
force-pushed
the
WaitForBedHeatersBetweenProbing
branch
4 times, most recently
from
9e9b0bf to
b9a1e3d
Compare
thinkyhead
force-pushed
the
WaitForBedHeatersBetweenProbing
branch
5 times, most recently
from
5d76c78 to
0a7b1b4
Compare
thinkyhead
force-pushed
the
WaitForBedHeatersBetweenProbing
branch
from
0a7b1b4 to
0d5b948
Compare
thinkyhead
force-pushed
the
WaitForBedHeatersBetweenProbing
branch
from
a0a05eb to
cb7a393
Compare
Co-Authored-By: Festivejelly <festivejelly@users.noreply.github.com>
thinkyhead
force-pushed
the
WaitForBedHeatersBetweenProbing
branch
from
cb7a393 to
feb9596
Compare
Author
|
Thanks for doing this. Sorry i was unable to complete the work. Life hit me with some...obstacles. |
Member
|
No problem, @Festivejelly. Life will sometimes do that! |
thinkyhead
pushed a commit
that referenced
this pull request
Sep 22, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an option to wait for the bed to heat back up between each probe. This applies to bed leveling and probe-based homing.
The reasoning behind this is that when heaters are disabled the bed can cool slightly but doesn't have enough time to heat back up between probes.
This code checks to see if the bed is at target temp. If it's below target temp, it will poll every 200ms until it reaches the target.
After a lot of testing I've determined that it helps accuracy of the probe quite significantly on some beds (those that tend to cool faster).
Counterpart to #10472