G29 - D parameter to quickly set square probing grid#7923
G29 - D parameter to quickly set square probing grid#7923MasterPIC wants to merge 1 commit intoMarlinFirmware:bugfix-1.1.xfrom MasterPIC:bugfix-1.1.x
Conversation
I added D parameter to quickly set a square (DxD mm^2) probing grid centered on the probing area
|
I just noticed D was already in use for dry run. So another letter should be used for this purpose... |
|
As the only usefulness for this would be for those few individuals who might have huge build platforms but only normally use the center for their standard prints, for everyone else I'd envision this more work t6o manage than just standard probing, so shouldn't this be a compile-time option ? Or maybe not... how much extra PROGMEM does it use ? :-D btw- looks like you may have to rebase your PR (or perhaps Github has changed the view yet again) |
|
@MasterPIC - did you intend to close this ? You should be able to rebase and push to your Regarding compile-time option, it would just require wrapping your code bits with the appropriate Regarding the switch parameter D, I'm not sure why we couldn't commandeer dry-run because I'm not sure what the difference is between it and "G29 T" (generate topology map). Here is the outputs: G29: G29 T G29 D |
|
By fixing the code as follows the new parameter requires 50 bytes of PROGMEM. I already added a pair of lines like these ones but I realized this change should affect several example config files... As for D parameter already in use, I opted for my printer for a "G" parameter to set a centered square grid. And probably, in case of need for PROGMEM, I'll remove D and T parameters and all related code since I'm not using them... But it's a personal preference. |
I added D parameter to quickly set a square (DxD mm^2) probing grid centered on the probing area