Skip to content

Revert PR 3648 to fix SD printing#3657

Merged
thinkyhead merged 1 commit intoMarlinFirmware:RCBugFixfrom
thinkyhead:rc_revert_3648_fix_sd_printing
May 2, 2016
Merged

Revert PR 3648 to fix SD printing#3657
thinkyhead merged 1 commit intoMarlinFirmware:RCBugFixfrom
thinkyhead:rc_revert_3648_fix_sd_printing

Conversation

@thinkyhead
Copy link
Member

Reverting #3648 which rejects ~.

@Blue-Marlin The character 0x7E is rather common in 8.3 filenames. In fact, it's the tilde ~ character. Maybe the last condition should be removed completely instead.

The character 0x7E is common in 8.3 filenames. Maybe the last condition
should be removed completely instead.
@thinkyhead thinkyhead merged commit 11b56a3 into MarlinFirmware:RCBugFix May 2, 2016
@thinkyhead thinkyhead deleted the rc_revert_3648_fix_sd_printing branch May 2, 2016 03:02
@Blue-Marlin
Copy link
Contributor

@thinkyhead
Sorry did not test for the tilde. It's the 0x7f = DEL what definitely should not occur.

@jbrazio jbrazio modified the milestone: 1.1.0 Jul 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants